-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new aa-comma-style all-except-single-line. #80
Add new aa-comma-style all-except-single-line. #80
Conversation
…ce "always" for multiple line AA but for single line AA it will enforce "no-dangling".
Can you show an example where an extra Maybe it's a bug because single line AA should probably not have a dangling coma even with the dangling rule. |
@ elsassph I want to be able to support
and
|
|
…ional comma for a single-line AA.
@elsassph Thanks. I made the change as you suggest. |
Thank you @elsassph. I think I have made all the required changes. |
Sorry @justinMBullard some tests seem to be failing... |
@elsassph Sorry there was a second test that I wasn't aware of that needed updating. I just fixed that. This is my first time working on this project and I am still learning how to navigate everything. Thank you for patients. I think everything should be good now. |
The
all-except-single-line
option will enforce "always" for multiple line AA but for single line AA it will enforce "no-dangling".The
all-except-single-line
option is here to help with creating more line independent when an AA is extended. For multiple line AA, always is preferred.Always
will allow for the addition to AA at the end without requiring a change to the previous line.However for a single line AA,
always
just adds an extra,
and does not create line independence. For a single line AA it is better to useno-dangling
. This will keep the AA smaller.