Prevent a double super call in subclasses
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
added a commit
to DataDog/dd-sdk-roku
that referenced
this pull request
Nov 22, 2022
[0.60.6](rokucommunity/brighterscript@v0.60.5...0.60.6) - 2022-11-08 - double `super` call transpile in subclasses ([#740](rokucommunity/brighterscript#740)) - issues with Roku doc scraper and adds missing components ([#736](rokucommunity/brighterscript#736)) [0.60.5](rokucommunity/brighterscript@v0.60.4...0.60.5) - 2022-11-03 - Refactor SymbolTable and AST parent logic so that SymbolTables get their parent symbol table from its own (AstNode) ([#732](rokucommunity/brighterscript#732)) - Significant performance boost in `validate()` by caching `getCallableByName` ([#739](rokucommunity/brighterscript#739)) - Add diagnostic when using namespaces as variables ([#738](rokucommunity/brighterscript#738)) - Fix crash in `getDefinition` ([#734](rokucommunity/brighterscript#734)) [0.60.4](rokucommunity/brighterscript@v0.60.3...0.60.4) - 2022-10-28 - Add `name` to symbol table ([#728](rokucommunity/brighterscript#728)) - Allow `continue` as local var ([#730](rokucommunity/brighterscript#730)) - language server semanticToken request now waits until validate finishes ([#727](rokucommunity/brighterscript#727)) [0.60.3](rokucommunity/brighterscript@v0.60.2...0.60.3) - 2022-10-20 - better parse recovery for unknown function parameter types ([#722](rokucommunity/brighterscript#722)) [0.60.2](rokucommunity/brighterscript@v0.60.1...0.60.2) - 2022-10-18 - if statement block var bug ([#698](rokucommunity/brighterscript#698)) [0.60.1](rokucommunity/brighterscript@v0.60.0...0.60.1) - 2022-10-18 - Beter location for bs1042 ([#719](rokucommunity/brighterscript#719)) [0.60.0](rokucommunity/brighterscript@v0.59.0...0.60.0) - 2022-10-10 - goto definition for enum statements and enum members ([#715](rokucommunity/brighterscript#715)) - nested namespace support ([#708](rokucommunity/brighterscript#708)) - upgrade to [[email protected]](https://github.com/rokucommunity/roku-deploy/blob/master/CHANGELOG.md#392---2022-10-03). Notable changes since 3.9.1: - Replace minimatch with picomatch ([roku-deploy#101](rokucommunity/roku-deploy#101)) - fixes signature help resolution for callexpressions ([#707](rokucommunity/brighterscript#707)) - Fix transpilation of simple else block with leading comment ([#712](rokucommunity/brighterscript#712))
xgouchet
added a commit
to DataDog/dd-sdk-roku
that referenced
this pull request
Nov 23, 2022
[0.60.6](rokucommunity/brighterscript@v0.60.5...0.60.6) - 2022-11-08 - double `super` call transpile in subclasses ([#740](rokucommunity/brighterscript#740)) - issues with Roku doc scraper and adds missing components ([#736](rokucommunity/brighterscript#736)) [0.60.5](rokucommunity/brighterscript@v0.60.4...0.60.5) - 2022-11-03 - Refactor SymbolTable and AST parent logic so that SymbolTables get their parent symbol table from its own (AstNode) ([#732](rokucommunity/brighterscript#732)) - Significant performance boost in `validate()` by caching `getCallableByName` ([#739](rokucommunity/brighterscript#739)) - Add diagnostic when using namespaces as variables ([#738](rokucommunity/brighterscript#738)) - Fix crash in `getDefinition` ([#734](rokucommunity/brighterscript#734)) [0.60.4](rokucommunity/brighterscript@v0.60.3...0.60.4) - 2022-10-28 - Add `name` to symbol table ([#728](rokucommunity/brighterscript#728)) - Allow `continue` as local var ([#730](rokucommunity/brighterscript#730)) - language server semanticToken request now waits until validate finishes ([#727](rokucommunity/brighterscript#727)) [0.60.3](rokucommunity/brighterscript@v0.60.2...0.60.3) - 2022-10-20 - better parse recovery for unknown function parameter types ([#722](rokucommunity/brighterscript#722)) [0.60.2](rokucommunity/brighterscript@v0.60.1...0.60.2) - 2022-10-18 - if statement block var bug ([#698](rokucommunity/brighterscript#698)) [0.60.1](rokucommunity/brighterscript@v0.60.0...0.60.1) - 2022-10-18 - Beter location for bs1042 ([#719](rokucommunity/brighterscript#719)) [0.60.0](rokucommunity/brighterscript@v0.59.0...0.60.0) - 2022-10-10 - goto definition for enum statements and enum members ([#715](rokucommunity/brighterscript#715)) - nested namespace support ([#708](rokucommunity/brighterscript#708)) - upgrade to [[email protected]](https://github.com/rokucommunity/roku-deploy/blob/master/CHANGELOG.md#392---2022-10-03). Notable changes since 3.9.1: - Replace minimatch with picomatch ([roku-deploy#101](rokucommunity/roku-deploy#101)) - fixes signature help resolution for callexpressions ([#707](rokucommunity/brighterscript#707)) - Fix transpilation of simple else block with leading comment ([#712](rokucommunity/brighterscript#712))
xgouchet
added a commit
to DataDog/dd-sdk-roku
that referenced
this pull request
Nov 23, 2022
[0.60.6](rokucommunity/brighterscript@v0.60.5...0.60.6) - 2022-11-08 - double `super` call transpile in subclasses ([#740](rokucommunity/brighterscript#740)) - issues with Roku doc scraper and adds missing components ([#736](rokucommunity/brighterscript#736)) [0.60.5](rokucommunity/brighterscript@v0.60.4...0.60.5) - 2022-11-03 - Refactor SymbolTable and AST parent logic so that SymbolTables get their parent symbol table from its own (AstNode) ([#732](rokucommunity/brighterscript#732)) - Significant performance boost in `validate()` by caching `getCallableByName` ([#739](rokucommunity/brighterscript#739)) - Add diagnostic when using namespaces as variables ([#738](rokucommunity/brighterscript#738)) - Fix crash in `getDefinition` ([#734](rokucommunity/brighterscript#734)) [0.60.4](rokucommunity/brighterscript@v0.60.3...0.60.4) - 2022-10-28 - Add `name` to symbol table ([#728](rokucommunity/brighterscript#728)) - Allow `continue` as local var ([#730](rokucommunity/brighterscript#730)) - language server semanticToken request now waits until validate finishes ([#727](rokucommunity/brighterscript#727)) [0.60.3](rokucommunity/brighterscript@v0.60.2...0.60.3) - 2022-10-20 - better parse recovery for unknown function parameter types ([#722](rokucommunity/brighterscript#722)) [0.60.2](rokucommunity/brighterscript@v0.60.1...0.60.2) - 2022-10-18 - if statement block var bug ([#698](rokucommunity/brighterscript#698)) [0.60.1](rokucommunity/brighterscript@v0.60.0...0.60.1) - 2022-10-18 - Beter location for bs1042 ([#719](rokucommunity/brighterscript#719)) [0.60.0](rokucommunity/brighterscript@v0.59.0...0.60.0) - 2022-10-10 - goto definition for enum statements and enum members ([#715](rokucommunity/brighterscript#715)) - nested namespace support ([#708](rokucommunity/brighterscript#708)) - upgrade to [[email protected]](https://github.com/rokucommunity/roku-deploy/blob/master/CHANGELOG.md#392---2022-10-03). Notable changes since 3.9.1: - Replace minimatch with picomatch ([roku-deploy#101](rokucommunity/roku-deploy#101)) - fixes signature help resolution for callexpressions ([#707](rokucommunity/brighterscript#707)) - Fix transpilation of simple else block with leading comment ([#712](rokucommunity/brighterscript#712))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when transpiling classes that was causing a double
super()call in the transpiled output. This was caused anytime there was a comment as the first statement in a classnew()body.Now we look for the first non comment in the
new()body.