Improve feature/pass-spec-directly #356
Conversation
|
|
@serut is attempting to deploy a commit to the Rohit Gohri's projects Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -20,7 +16,7 @@ function Redoc(props: RedocProps): JSX.Element { | |||
| const { className, optionsOverrides, url, themeId } = props; | |||
| const { options } = useSpecOptions(themeId, optionsOverrides); | |||
|
|
|||
| if (getIsExternalUrl(url)) { | |||
There was a problem hiding this comment.
this is going to completely disable SSR for anyone using url, if that is what you want then we can just add that as an option I think rather than changing behavior for existing users.
We won't need downloadSpecUrl option, just a ssr option, by default true but which can be disabled to always use client side rendering and skip the bundling logic
There was a problem hiding this comment.
Allright I will try to do that change
This MR fixes #347
getIsExternalUrlfunctionthemeIdtoApiSchemadownloadSpecUrlproperty toRedocPropsand co, to separate the behavior fromurlthat was doing 2 different things