Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nmtui & nmcli prompt to 'myip' output when no IP address found #96 #122

Conversation

phillxnet
Copy link
Member

Usability enhancement to prompt folks to use NetworkManager command line tools when our 'myip' helper finds no IP address.

Fixes #96
Ready for review.

Testing

Edited a local installer instance of myip as per proposed change and tested as per issue text:

myip-noip-fix

…ckstor#96

Usability enhancement to prompt folks to use NetworkManager command
line tools when our 'myip' helper finds no IP address.
@phillxnet
Copy link
Member Author

Linking to a related, in part, documentation issue regarding static ip setup:
rockstor/rockstor-doc#358

Copy link
Member

@FroggyFlox FroggyFlox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phillxnet ,
Thanks for taking care of that one!
I only have minor style suggestion in case it reads better to you.

root/root/bin/myip Outdated Show resolved Hide resolved
@phillxnet
Copy link
Member Author

phillxnet commented Aug 22, 2022

Final testing

An installer was build with this patch pre-applied. The VM enacted an ethernet cable unplugged scenario (see link-status below), to effect no dhcp available via no ethernet connection. An install was then carried out, effectively with-out the ethernet cable plugged in.

The 'myip' utility reacted as intended:
myip-noip-fix_installer-test

nmtui was then used to

  1. Configure a static ip
  2. enable this connection.
    The VM was then instructed to re-connect, live, the ethernet cable via:

link-status-VM-setting

And the consequent "nmcli" output indicated a transition to a wired carrier:

nmcli device show | grep WIRED.PROPERTIES.CARRIER
WIRED-PROPERTIES.CARRIER:               on

Thus the resulting static IP was applied to the newly live (freshly plugged in) connection and the Rockstor Web-UI was accessible via the static IP set via nmtui; including after a reboot.

Caveat

Post our static ip test above we have a not directly related failure in console messaging on future boot messages:

web-ui_is_accessible-messaging-issue

This can and should be addressed in it's own issue and relates to rockstor-core code that re-writes our console message.

[EDIT]. Note that this message missing the static ip set was only observed after the first reboot. Subsequent reboots had the expected entry for the non localloop address:
non-first-reboot-web-ui_is_accessible_message_ok

@phillxnet
Copy link
Member Author

@FroggyFlox Given the above functional end-to-end test I think we are good on this one. Thanks again for the review and I'll merge directly.

@phillxnet phillxnet merged commit 601d9f8 into rockstor:master Aug 22, 2022
@phillxnet phillxnet deleted the 96_Empty_output_from_myip_when_network_connection_is_unavailable branch August 22, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty output from myip when network connection is unavailable
2 participants