Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds PIDSubsystem and TrapezoidProfileSubsystem to Commands2. #34

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Adds PIDSubsystem and TrapezoidProfileSubsystem to Commands2. #34

merged 1 commit into from
Dec 8, 2023

Conversation

lospugs
Copy link
Contributor

@lospugs lospugs commented Dec 6, 2023

…/robotpy-commands-v2#28

virtuald
virtuald reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@virtuald virtuald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting and mypy failed

commands2/pidsubsystem.py Outdated Show resolved Hide resolved
commands2/pidsubsystem.py Outdated Show resolved Hide resolved
@lospugs
Copy link
Contributor Author

lospugs commented Dec 7, 2023

Is the overall preference that I squash the commits into one and push again?

@virtuald
Copy link
Member

virtuald commented Dec 7, 2023

Yes, I like commits to tell a useful history most of the time.

@virtuald virtuald force-pushed the pid_and_trapezoidprofile branch from fd84e8d to 4ceae13 Compare December 8, 2023 23:48
@virtuald virtuald merged commit 0608bb8 into robotpy:main Dec 8, 2023
19 checks passed
@virtuald virtuald mentioned this pull request Jan 20, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virtuald virtuald virtuald left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lospugs @virtuald