Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression(s) introduced by YCMEPHelper refactor #458

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Aug 14, 2024

Each commit fix a different problem.

Error on old CMake version

CMake Error at build/_deps/ycm-src/modules/YCMEPHelper.cmake:1189 (_ep_get_tls_version):
  Unknown CMake command "_ep_get_tls_version".
Call Stack (most recent call first):
  cmake/BuildYCM.cmake:8 (ycm_ep_helper)
  build/_deps/ycm-src/modules/FindOrBuildPackage.cmake:205 (include)
  cmake/BuildYARP.cmake:8 (find_or_build_package)
  build/_deps/ycm-src/modules/FindOrBuildPackage.cmake:205 (include)
  cmake/RobotologySuperbuildLogic.cmake:68 (find_or_build_package)
  CMakeLists.txt:68 (include)

Fixed by 9c3a16b .

Error on --no-checkout passed to fetch

FAILED: src/walking-controllers/CMakeFiles/YCMStamp/walking-controllers-download /home/giovannif/robotology-superbuild/build/src/walking-controllers/CMakeFiles/YCMStamp/walking-controllers-download 
cd /home/giovannif/robotology-superbuild/src && /home/giovannif/mambaforge/envs/robsub/bin/cmake -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P /home/giovannif/robotology-superbuild/build/src/walking-controllers/CMakeFiles/YCMTmp/walking-controllers-gitsafeclone.cmake && /home/giovannif/mambaforge/envs/robsub/bin/cmake -E touch /home/giovannif/robotology-superbuild/build/src/walking-controllers/CMakeFiles/YCMStamp/walking-controllers-download
CMake Warning at /home/giovannif/robotology-superbuild/build/src/walking-controllers/CMakeFiles/YCMTmp/walking-controllers-gitsafeclone.cmake:56 (message):
  Repository URL is different.  Renaming 'origin' remote to
  'origin.20240814113552'
 
 
error: unknown option `no-checkout'
usage: git fetch [<options>] [<repository> [<refspec>...]]
   or: git fetch [<options>] <group>
   or: git fetch --multiple [<options>] [(<repository> | <group>)...]
   or: git fetch --all [<options>]
 
    -v, --verbose         be more verbose
    -q, --quiet           be more quiet
    --all                 fetch from all remotes
    --set-upstream        set upstream for git pull/fetch
    -a, --append          append to

Fixed by d399c22 .

Impossible to copy gitsafeclone-lastrun.txt

[7/480] Performing download step for 'OsqpEigen'
FAILED: src/OsqpEigen/CMakeFiles/YCMStamp/OsqpEigen-download /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/OsqpEigen/CMakeFiles/YCMStamp/OsqpEigen-download 
cd /home/runner/work/robotology-superbuild/robotology-superbuild/src && /home/runner/miniconda3/envs/test/bin/cmake -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/OsqpEigen/CMakeFiles/YCMTmp/OsqpEigen-gitsafeclone.cmake && /home/runner/miniconda3/envs/test/bin/cmake -E touch /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/OsqpEigen/CMakeFiles/YCMStamp/OsqpEigen-download
Cloning into 'OsqpEigen'...
Already on 'master'
Your branch is up to date with 'origin/master'.
Error copying file "/OsqpEigen-gitinfo.txt" to "/OsqpEigen-gitsafeclone-lastrun.txt".
CMake Error at /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/OsqpEigen/CMakeFiles/YCMTmp/OsqpEigen-gitsafeclone.cmake:150 (message):
  Failed to copy script-last-run stamp file:
  '/OsqpEigen-gitsafeclone-lastrun.txt'


[8/480] Performing download step for 'RobotTestingFramework'
FAILED: src/RobotTestingFramework/CMakeFiles/YCMStamp/RobotTestingFramework-download /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/RobotTestingFramework/CMakeFiles/YCMStamp/RobotTestingFramework-download 
cd /home/runner/work/robotology-superbuild/robotology-superbuild/src && /home/runner/miniconda3/envs/test/bin/cmake -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/RobotTestingFramework/CMakeFiles/YCMTmp/RobotTestingFramework-gitsafeclone.cmake && /home/runner/miniconda3/envs/test/bin/cmake -E touch /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/RobotTestingFramework/CMakeFiles/YCMStamp/RobotTestingFramework-download
Cloning into 'RobotTestingFramework'...
Already on 'master'
Your branch is up to date with 'origin/master'.
Error copying file "/RobotTestingFramework-gitinfo.txt" to "/RobotTestingFramework-gitsafeclone-lastrun.txt".
CMake Error at /home/runner/work/robotology-superbuild/robotology-superbuild/b/src/RobotTestingFramework/CMakeFiles/YCMTmp/RobotTestingFramework-gitsafeclone.cmake:150 (message):
  Failed to copy script-last-run stamp file:
  '/RobotTestingFramework-gitsafeclone-lastrun.txt'

Fixed by 6af4a37 .

"Failed to update submodules in:" when using CMake 3.16

Fixed by df64cec . As we are trying to get rid of the vendored ExternalProject, as this problem is just with CMake 3.16, we stick to use the venored ExternalProject in CMake < 3.22, with the idea that eventually we will drop CMake 3.16 support (see robotology/robotology-superbuild#1439).

@traversaro traversaro changed the title Fix regression introduced by YCMEPHelper refactor Fix regression(s) introduced by YCMEPHelper refactor Aug 14, 2024
@traversaro traversaro merged commit 5c1f89a into master Aug 14, 2024
18 checks passed
@traversaro traversaro deleted the fixrobsub1690 branch August 14, 2024 13:27
traversaro added a commit to robotology/robotology-superbuild that referenced this pull request Aug 14, 2024
It should not be necessary after robotology/ycm-cmake-modules#458 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant