Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform-specific flags for NEON. #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jul 21, 2018

Along with some upstream changes (below), this allows a full build on armv7hl.

Auburn/FastNoiseSIMD@3287340
Auburn/FastNoiseSIMD@575c004
Auburn/FastNoiseSIMD#27
Auburn/FastNoiseSIMD#32

@QuLogic
Copy link
Contributor Author

QuLogic commented Jul 21, 2018

Ah, I wasn't too sure how well this would work on Windows; will have to tweak it a little bit.

@QuLogic
Copy link
Contributor Author

QuLogic commented Jul 21, 2018

OK, fixed Windows (I think) and also aarch64, which supports NEON, but doesn't need a flag for it.

@robbmcleod
Copy link
Owner

robbmcleod commented Jul 24, 2018

I think then that I should investigate making the pyfastnoisesimd\fastnoisesimd directory a submodule. I think the only added file is x86_flags.h, which doesn't need to be in the repo.

Edit: x86_flags.h is being defined to replace some macros in FastNoiseSIMD.h which otherwise require the user to commit out/in lines before compilation. So (speaking to myself here), what are the options here? Do a PR against FastNoiseSIMD to make a separate defines file? Some string-replacements in the Python setup.py?

@QuLogic
Copy link
Contributor Author

QuLogic commented Aug 12, 2018

PS, I've heard through some NumPy issues that Shippable is starting to provide ARMv8 CI.

@robbmcleod
Copy link
Owner

Good to know thanks. I see Auburns still hasn't accepted your PR so I could rebase off your repo for now and forget the submodule in the short-term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants