add support in .fetch_results for retrieving results in multiple pages

[benubah]

This change improves the existing code based on the unexpected behavior reported in the following issue #55

[ledell]

Suggested change

	if((length(records) < total_records) & !is.null(res$headers$link)){
	if ((length(records) < total_records) & !is.null(res$headers$link)) {

[ledell]

Suggested change

	for(i in 1:(offsetn - 1)) {
	for (i in 1:(offsetn - 1)) {

[ledell]

Hi @benubah I support the changes, except that I got an error when running the code above. Since I needed the updated find_groups() function from #48 to try the code example, I copy-pasted the function in to my shell, so this might have caused an issue, but I ran the code and got an error. Can you double check that this works?

> all_ruser_groups <- find_groups(text = "r-project-for-statistical-computing", fields = "past_event_count, upcoming_event_count, last_event, topics", api_key = meetup_api_key)
Downloading 482 record(s)...Error in as_mapper(.f, ...) : argument ".f" is missing, with no default

I think it makes sense to add these changes in the other PR since they are related to the other PR and required to make that one fully functional (and also makes it easier to test).

[benubah]

@ledell Please see a screenshot of my terminal. It works smoothly for me.
The PR updates .quick_fetch() and .fetch_results(). If you look at the full git diff ec0943b for internals.R from start to finish, few insertions of offset as an argument were made. See what .quick_fetch() now looks like below:
But, I have now added the changes to the other PR #48 to make testing easier.

I did not attach the meetupr package. I just sourced the improved internals.R and find_groups()

.quick_fetch <- function(api_url,
                         api_key = NULL,
                         event_status = NULL,
                         offset = 0,
                         ...) 

Feel free to let me know if it still does not work.

[ledell]

@benubah Thanks, I assume the error I got had to do with me copy/pasting code. I'll try it out on the other PR...

[ledell]

Hi @benubah can you fix the conflict so we can get this merged? Sorry again for not merging this last year.

[maelle]

👋 @benubah

[maelle]

Given the changes that were made in the default branch, and given that some functions already handle pagination, I think it might be easier to start from scratch/ using code from these functions.