Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow using alternate crate root with derive macro #30

Merged
merged 1 commit into from
Feb 23, 2023
Merged

allow using alternate crate root with derive macro #30

merged 1 commit into from
Feb 23, 2023

Conversation

samlich
Copy link
Contributor

@samlich samlich commented Feb 17, 2023

Needed for rkyv/rkyv#343.

Adding #[check_bytes(crate = "rkyv::bytecheck")], or similar, allows using a different crate root.

@samlich samlich mentioned this pull request Feb 17, 2023
Merged
@djkoloski
Copy link
Collaborator

This looks correct to me, could you add a test to bytecheck_test that exercises this functionality?

@samlich
Copy link
Contributor Author

samlich commented Feb 22, 2023

Added

@djkoloski djkoloski merged commit af58733 into rkyv:master Feb 23, 2023
@djkoloski
Copy link
Collaborator

Thanks for the PR!

@samlich samlich deleted the crate-root branch February 23, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samlich @djkoloski