Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Update / Colour Scheme buttons don't seem to work #138

Closed
arp242 opened this issue Aug 31, 2024 · 4 comments
Closed

Live Update / Colour Scheme buttons don't seem to work #138

arp242 opened this issue Aug 31, 2024 · 4 comments
Assignees
@bgentry
Labels
bug Something isn't working

Comments

@arp242
Copy link
Contributor

arp242 commented Aug 31, 2024

The buttons at the top don't seem to do anything? It opens, I select something, but nothing changes, and when I open it again the old value is still selected.

Tested in Firefox and Chromium.

Version baaa2e5

out.ogv.mp4
@bgentry
Copy link
Contributor

bgentry commented Sep 1, 2024

Must have regressed in a dependency upgrade, sorting that out now. Thanks for the report!

@bgentry
Copy link
Contributor

bgentry commented Sep 1, 2024

@arp242 can you confirm how you're using this? Interestingly I'm getting this on ui.riverqueue.com, but not when I try to reproduce locally (even with built assets). Thinking it might be something specific to the embedded handler somehow.

@bgentry bgentry self-assigned this Sep 1, 2024
@bgentry bgentry added the bug Something isn't working label Sep 1, 2024
@arp242
Copy link
Contributor Author

arp242 commented Sep 1, 2024 •
edited
Loading

I first noticed when running from the Docker container, bb9f755ef45e.

I also ran it directly (npm install, npm run build, go build, DATABASE_URL=.. ./riverui) because I wanted to look at fixing it as it seemed a simple problem, but all this React stuff confused me so I gave up on that.

I just tried running with LIVE_FS=y, DEV=y, and LIVE_FS=y DEV=y, and that doesn't seem to make a difference.

I can also confirm that https://ui.riverqueue.com is broken for me.

bgentry added a commit that referenced this issue Sep 1, 2024
@bgentry
downgrade @headlessui/react to fix listbox bugs
59c36d1 
Fixes #138.
bgentry added a commit that referenced this issue Sep 1, 2024
@bgentry
downgrade @headlessui/react to fix listbox bugs
b04af31 
Fixes #138.
@bgentry bgentry mentioned this issue Sep 1, 2024
Merged
@bgentry
Copy link
Contributor

bgentry commented Sep 1, 2024

Fix is coming in #139 / v0.5.1 shortly, thanks again for finding + reporting 🙏

@bgentry bgentry closed this as completed in 3fc0192 Sep 1, 2024
bgentry added a commit that referenced this issue Sep 2, 2024
@bgentry
re-upgrade headless UI w/ positioning fixes
e9fb555 
The issue in #138 (fixed by #139) was the result of positioning the
listbox using tailwind classes instead of the `Listbox`'s own attrs for
positioning. Using the builtin positioning option seems to have fixed
this even on the latest version.
@bgentry bgentry mentioned this issue Sep 2, 2024
Merged
bgentry added a commit that referenced this issue Sep 2, 2024
@bgentry
re-upgrade headless UI w/ positioning fixes
de92b3f 
The issue in #138 (fixed by #139) was the result of positioning the
listbox using tailwind classes instead of the `Listbox`'s own attrs for
positioning. Using the builtin positioning option seems to have fixed
this even on the latest version.
bgentry added a commit that referenced this issue Sep 2, 2024
@bgentry
Listbox positioning fixes, re-upgrade headlessui (#146)
d87d174 
* rely on builtin Listbox positioning + z-index class

* re-upgrade headless UI w/ positioning fixes

The issue in #138 (fixed by #139) was the result of positioning the
listbox using tailwind classes instead of the `Listbox`'s own attrs for
positioning. Using the builtin positioning option seems to have fixed
this even on the latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgentry bgentry

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgentry @arp242