feat: introduce PROCTIME() #9088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhao-su
added
the
user-facing-changes
github-actions
bot
added
type/feature
and removed
user-facing-changes
Codecov Report
@@ Coverage Diff @@
## main #9088 +/- ##
========================================
Coverage 70.87% 70.88%
========================================
Files 1197 1198 +1
Lines 199011 199125 +114
========================================
+ Hits 141057 141148 +91
- Misses 57954 57977 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yuhao-su
added
the
user-facing-changes
github-actions
bot
removed
the
user-facing-changes
BugenZhao
reviewed
Apr 11, 2023
chenzl25
approved these changes
Apr 11, 2023
BugenZhao
approved these changes
Apr 12, 2023
xiangjinwu
reviewed
Apr 12, 2023
Comment on lines
+50
to
+58
| fn return_type(&self) -> DataType { | ||
| DataType::Timestamptz | ||
| } | ||
|
|
||
| async fn eval_v2(&self, input: &DataChunk) -> Result<ValueImpl> { | ||
| let proctime = CONTEXT | ||
| .try_with(|context| context.get_physical_time()) | ||
| .map_err(|_| ExprError::Context)?; | ||
| let datum = Some(ScalarImpl::Int64(proctime as i64)); |
There was a problem hiding this comment.
Timestamptz is in microseconds but seems Epoch::physical_time is in milliseconds? And it seems to be since risingwave epoch rather than unix epoch
There was a problem hiding this comment.
Good point. The interfaces of Epoch are ambiguous without including the time unit in the names.
github-actions
bot
added
the
user-facing-changes
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist For Contributors
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934)../risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
We can define a processing time on TABLE/SOURCE, which reflects the time a record is inserted in RisingWave.
Release note