Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(regress): enable interval #8438

Merged
merged 5 commits into from
Mar 9, 2023
Merged

test(regress): enable interval #8438

merged 5 commits into from
Mar 9, 2023

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Mar 9, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Enable PostgreSQL regress test interval:

  • Modified tests
    • Use supported input syntax (without @ or ago)
    • TEMP TABLE
    • COPY FROM STDIN -> INSERT
  • Disabled (--@ ) failing cases:
    • overflow panic during order-by comparison
    • overflowing input wrapped rather than rejected
    • multiplication and division
    • input syntax with +, decimal point, more units (e.g. millisecond, millenniums)
    • input with repeated fields not rejected
    • precision loss of microsecond
    • output with +
  • Disabled (--@ ) unsupported cases:
    • extract/date_part
    • justify_hours/justify_days/justify_interval
    • interval_hash
    • make_interval
    • A to B
    • other input syntax

Plan to fix the issues above before moving on to timestamptz and horology.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.

@github-actions github-actions bot added the component/test Test related issue. label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #8438 (2df36ef) into main (7f15e9e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #8438      +/-   ##
==========================================
- Coverage   71.65%   71.64%   -0.01%     
==========================================
  Files        1135     1135              
  Lines      185621   185621              
==========================================
- Hits       132998   132985      -13     
- Misses      52623    52636      +13     
Flag Coverage Δ
rust 71.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/binder/select.rs 92.04% <0.00%> (-0.31%) ⬇️
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
src/batch/src/task/task_execution.rs 51.25% <0.00%> (-0.50%) ⬇️
src/object_store/src/object/mod.rs 48.07% <0.00%> (-0.21%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.38% <0.00%> (-0.20%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.27% <0.00%> (+0.10%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 65.97% <0.00%> (+0.51%) ⬆️
...torage/src/hummock/local_version/pinned_version.rs 89.37% <0.00%> (+0.62%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu requested a review from lmatz March 9, 2023 06:49
@xiangjinwu xiangjinwu added this pull request to the merge queue Mar 9, 2023
Merged via the queue into main with commit 279bfbf Mar 9, 2023
@xiangjinwu xiangjinwu deleted the test-regress-interval branch March 9, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants