Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streaming): use correct dist key in pk in state table for hash join #8404

Merged
merged 7 commits into from
Mar 8, 2023

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Mar 7, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • use correct dist key in pk in state table for hash join

#8377
close #7698

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Bug fix label Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #8404 (0feabdb) into main (e6f2561) will increase coverage by 0.03%.
The diff coverage is 87.71%.

@@            Coverage Diff             @@
##             main    #8404      +/-   ##
==========================================
+ Coverage   71.62%   71.65%   +0.03%     
==========================================
  Files        1135     1135              
  Lines      185458   185432      -26     
==========================================
+ Hits       132835   132874      +39     
+ Misses      52623    52558      -65     
Flag Coverage Δ
rust 71.65% <87.71%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/common/table/state_table.rs 88.60% <28.57%> (-0.58%) ⬇️
src/frontend/src/optimizer/plan_node/stream.rs 15.78% <90.90%> (+1.32%) ⬆️
...ontend/src/optimizer/plan_node/stream_hash_join.rs 94.51% <96.55%> (-0.01%) ⬇️
src/frontend/src/catalog/table_catalog.rs 93.87% <100.00%> (+0.06%) ⬆️
...tend/src/optimizer/plan_node/stream_materialize.rs 95.81% <100.00%> (+0.01%) ⬆️
src/frontend/src/optimizer/plan_node/utils.rs 91.81% <100.00%> (+0.30%) ⬆️
...rc/storage/hummock_sdk/src/filter_key_extractor.rs 93.90% <100.00%> (+0.01%) ⬆️
...frontend/src/scheduler/hummock_snapshot_manager.rs 60.00% <0.00%> (-0.48%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.27% <0.00%> (+0.10%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/frontend/src/catalog/table_catalog.rs Outdated Show resolved Hide resolved
e2e_test/streaming/bug_fixes/issue_7698.slt Show resolved Hide resolved
@yuhao-su yuhao-su enabled auto-merge March 8, 2023 06:51
@yuhao-su yuhao-su added this pull request to the merge queue Mar 8, 2023
Merged via the queue into main with commit 015800f Mar 8, 2023
@yuhao-su yuhao-su deleted the yuhao/vnode151 branch March 8, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panicked at vnode 151 should not be accessed by this table
2 participants