Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scale): cover more operators in nexmark chaos tests #8198

Merged
merged 11 commits into from
Feb 27, 2023

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Feb 27, 2023

Signed-off-by: Bugen Zhao [email protected]
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR adds some tests to cover more operators in nexmark chaos tests.

  • Add watermark column for nexmark-chaos and nexmark_source.yaml, to cover WatermarkFilter. Watermark does not survive scaling test, will investigate later.
  • q15: Covers append-only hash aggregation with distinct.
  • q18: Covers group top-n (possibly deduplication in the future).
  • q106: self-made, covers two-phase stateful simple aggregation. (Close test: scaling of 2-phase aggregation is not covered #7788)

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@github-actions github-actions bot added the component/test Test related issue. label Feb 27, 2023
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BugenZhao
Copy link
Member Author

Let's wait for #7623 getting merged and also add these queries to recovery test.

@wangrunji0408
Copy link
Contributor

Let's wait for #7623 getting merged and also add these queries to recovery test.

Just found a new bug from this PR. I've retried and I am not sure if this run is lucky enough to let it merged. 🤣

Copy link
Member Author

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😟

@@ -37,11 +37,14 @@ impl NexmarkCluster {
conf: Configuration,
split_num: usize,
event_num: Option<usize>,
watermark: bool,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watermark operators do not survive the scaling test, so I've made this always false now. Will investigate it later.

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao enabled auto-merge February 27, 2023 11:09
@BugenZhao BugenZhao added this pull request to the merge queue Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #8198 (e99f66f) into main (59aec76) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #8198      +/-   ##
==========================================
- Coverage   71.77%   71.76%   -0.01%     
==========================================
  Files        1130     1130              
  Lines      181548   181555       +7     
==========================================
- Hits       130303   130290      -13     
- Misses      51245    51265      +20     
Flag Coverage Δ
rust 71.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/common/table/state_table.rs 85.21% <0.00%> (-0.68%) ⬇️
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
...frontend/src/scheduler/hummock_snapshot_manager.rs 60.00% <0.00%> (-0.48%) ⬇️
src/object_store/src/object/mod.rs 48.65% <0.00%> (-0.21%) ⬇️
src/storage/src/hummock/sstable_store.rs 64.77% <0.00%> (-0.16%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.88% <0.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit de37916 Feb 27, 2023
@BugenZhao BugenZhao deleted the bz/watermark-in-nexmark branch February 27, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: scaling of 2-phase aggregation is not covered
3 participants