-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(scale): cover more operators in nexmark chaos tests #8198
Conversation
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's wait for #7623 getting merged and also add these queries to recovery test. |
Just found a new bug from this PR. I've retried and I am not sure if this run is lucky enough to let it merged. 🤣 |
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😟
@@ -37,11 +37,14 @@ impl NexmarkCluster { | |||
conf: Configuration, | |||
split_num: usize, | |||
event_num: Option<usize>, | |||
watermark: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watermark operators do not survive the scaling test, so I've made this always false
now. Will investigate it later.
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #8198 +/- ##
==========================================
- Coverage 71.77% 71.76% -0.01%
==========================================
Files 1130 1130
Lines 181548 181555 +7
==========================================
- Hits 130303 130290 -13
- Misses 51245 51265 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Bugen Zhao [email protected]
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds some tests to cover more operators in nexmark chaos tests.
Add watermark column for nexmark-chaos andWatermark does not survive scaling test, will investigate later.nexmark_source.yaml
, to coverWatermarkFilter
.distinct
.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note