Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix the deterministic kafka source test #7733

Merged
merged 8 commits into from
Feb 8, 2023
Merged

Conversation

wangrunji0408
Copy link
Contributor

@wangrunji0408 wangrunji0408 commented Feb 7, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

fix #7633

@github-actions github-actions bot added the type/fix Bug fix label Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #7733 (cfd679a) into main (b6fe18e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7733      +/-   ##
==========================================
- Coverage   71.62%   71.62%   -0.01%     
==========================================
  Files        1098     1098              
  Lines      174866   174866              
==========================================
- Hits       125249   125241       -8     
- Misses      49617    49625       +8     
Flag Coverage Δ
rust 71.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/group_top_n.rs 68.23% <0.00%> (-6.48%) ⬇️
src/source/src/row_id.rs 90.90% <0.00%> (-1.14%) ⬇️
...frontend/src/scheduler/hummock_snapshot_manager.rs 60.00% <0.00%> (-0.48%) ⬇️
src/object_store/src/object/mod.rs 51.30% <0.00%> (ø)
src/storage/src/hummock/sstable_store.rs 64.73% <0.00%> (ø)
src/common/src/cache.rs 97.26% <0.00%> (+0.10%) ⬆️
src/common/src/types/ordered_float.rs 31.25% <0.00%> (+0.19%) ⬆️
src/object_store/src/object/mem.rs 87.25% <0.00%> (+0.38%) ⬆️
src/meta/src/hummock/mock_hummock_meta_client.rs 66.31% <0.00%> (+0.52%) ⬆️
...torage/src/hummock/local_version/pinned_version.rs 89.37% <0.00%> (+0.62%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit e5004c3 into main Feb 8, 2023
@mergify mergify bot deleted the wrj/weird-panic branch February 8, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deterministic test: kafka producer panicked at 'called Option::unwrap() on a None value
3 participants