feat: implement function split_part

[alissa-tung]

What's changed and what's your intention?

implement split_part

Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#2791
meta #112

[CLAassistant]

All committers have signed the CLA.

[alissa-tung]

cc @TennyZhuang @skyzh @xiangjinwu

[xiangjinwu]

Nice work! Just some minor things:

[xiangjinwu]

https://github.com/singularity-data/risingwave/runs/6621101096?check_suite_focus=true#step:10:65

error: unresolved link to `crate::expr::type_inference::build_type_derive_map`
  --> src/frontend/src/expr/function_call.rs:93:21
   |
93 |     /// [elsewhere](crate::expr::type_inference::build_type_derive_map).
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `type_inference` in module `expr`
   |
note: the lint level is defined here
  --> src/frontend/src/lib.rs:26:9
   |
26 | #![deny(rustdoc::broken_intra_doc_links)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not document `risingwave_frontend`

[alissa-tung]

https://github.com/singularity-data/risingwave/runs/6621101096?check_suite_focus=true#step:10:65

error: unresolved link to `crate::expr::type_inference::build_type_derive_map`
  --> src/frontend/src/expr/function_call.rs:93:21
   |
93 |     /// [elsewhere](crate::expr::type_inference::build_type_derive_map).
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `type_inference` in module `expr`
   |
note: the lint level is defined here
  --> src/frontend/src/lib.rs:26:9
   |
26 | #![deny(rustdoc::broken_intra_doc_links)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not document `risingwave_frontend`

https://github.com/singularity-data/risingwave/runs/6621101096?check_suite_focus=true#step:10:65

error: unresolved link to `crate::expr::type_inference::build_type_derive_map`
  --> src/frontend/src/expr/function_call.rs:93:21
   |
93 |     /// [elsewhere](crate::expr::type_inference::build_type_derive_map).
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `type_inference` in module `expr`
   |
note: the lint level is defined here
  --> src/frontend/src/lib.rs:26:9
   |
26 | #![deny(rustdoc::broken_intra_doc_links)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not document `risingwave_frontend`

@xiangjinwu

I thought it is caused by visibility.
c3ce096
workaround

[xiangjinwu]

I thought it is caused by visibility. c3ce096 workaround

Yes it is due to visibility. But we should not make things pub simply for references in docs. As the references are for developers updating the code rather than calling the code, maybe they should not be part of public doc. (i.e. use // rather than /// for parts explaining type inference vs FunctionCall new)

[codecov]

Codecov Report

Merging #2822 (7375f4b) into main (97a7247) will decrease coverage by 0.00%.
The diff coverage is 70.86%.

@@            Coverage Diff             @@
##             main    #2822      +/-   ##
==========================================
- Coverage   72.66%   72.65%   -0.01%     
==========================================
  Files         701      702       +1     
  Lines       92185    92310     +125     
==========================================
+ Hits        66983    67072      +89     
- Misses      25202    25238      +36     

Flag	Coverage Δ
rust	72.65% <70.86%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/common/src/array/mod.rs	73.02% <ø> (ø)
src/common/src/error.rs	69.37% <0.00%> (+0.11%)	⬆️
src/expr/src/expr/expr_ternary_bytes.rs	79.48% <0.00%> (-9.09%)	⬇️
src/expr/src/expr/mod.rs	47.72% <0.00%> (-1.11%)	⬇️
src/expr/src/expr/build_expr_from_prost.rs	66.44% <18.51%> (-3.07%)	⬇️
src/expr/src/vector_op/split_part.rs	95.34% <95.34%> (ø)
src/expr/src/vector_op/replace.rs	100.00% <100.00%> (ø)
src/frontend/src/binder/expr/function.rs	81.29% <100.00%> (+0.13%)	⬆️
src/frontend/src/expr/function_call.rs	99.37% <100.00%> (+0.01%)	⬆️
src/frontend/src/expr/type_inference.rs	98.86% <100.00%> (+<0.01%)	⬆️
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[alissa-tung]

I thought it is caused by visibility. c3ce096 workaround

Yes it is due to visibility. But we should not make things pub simply for references in docs. As the references are for developers updating the code rather than calling the code, maybe they should not be part of public doc. (i.e. use // rather than /// for parts explaining type inference vs FunctionCall new)

ok. I am going to revert that commit and use double for now

[alissa-tung]

cc @xiangjinwu done

[xiangjinwu]

Thank you for your contribution!