Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): add support for abs function #2531

Merged
merged 3 commits into from
May 18, 2022

Conversation

xiaoyong-z
Copy link
Contributor

@xiaoyong-z xiaoyong-z commented May 15, 2022

Apart from add support for abs function, this pr also adds gen_unary_atm_expr macro and reconstruct previous neg function with gen_unary_atm_expr

Signed-off-by: xyz [email protected]

What's changed and what's your intention?

  1. add support for abs function
  2. add gen_unary_atm_expr macro, lator we can use this marco to support other unary function
  3. reconstruct previous neg function with new gen_unary_atm_expr

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#112

Apart from add support for abs function, this pr also adds gen_unary_atm_expr macro and reconstruct previous neg function with gen_unary_atm_expr

Signed-off-by: xyz <[email protected]>
@fuyufjh fuyufjh requested a review from TennyZhuang May 16, 2022 03:40
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/expr/src/expr/expr_unary.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #2531 (73b9ece) into main (6b7d5b7) will decrease coverage by 0.01%.
The diff coverage is 44.11%.

@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
- Coverage   72.17%   72.15%   -0.02%     
==========================================
  Files         674      674              
  Lines       87831    87860      +29     
==========================================
+ Hits        63395    63399       +4     
- Misses      24436    24461      +25     
Flag Coverage Δ
rust 72.15% <44.11%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/decimal.rs 79.84% <0.00%> (-2.15%) ⬇️
src/expr/src/vector_op/arithmetic_op.rs 76.26% <0.00%> (-3.22%) ⬇️
src/expr/src/expr/expr_unary.rs 75.72% <50.00%> (-0.25%) ⬇️
src/expr/src/expr/mod.rs 47.61% <100.00%> (ø)
src/frontend/src/binder/expr/function.rs 91.45% <100.00%> (+0.07%) ⬆️
src/frontend/src/expr/type_inference.rs 97.91% <100.00%> (+0.03%) ⬆️
src/meta/src/model/barrier.rs 78.57% <0.00%> (-3.58%) ⬇️
src/connector/src/filesystem/file_common.rs 79.46% <0.00%> (-1.34%) ⬇️
src/storage/src/object/disk.rs 94.50% <0.00%> (-0.27%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fuyufjh
Copy link
Member

fuyufjh commented May 16, 2022

Please fix the conflicts

@TennyZhuang TennyZhuang merged commit 06c7fab into risingwavelabs:main May 18, 2022
@xiangjinwu xiangjinwu added the user-facing-changes Contains changes that are visible to users label May 25, 2022
@xiaoyong-z xiaoyong-z deleted the abs branch May 31, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants