-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): support cast from number to varchar #2522
feat(expr): support cast from number to varchar #2522
Conversation
cfc0b27
to
dca3e30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! It seems we can also replace bool_to_str
with general_to_string
now?
clippy failed
|
Signed-off-by: xyz <[email protected]>
51b8b5d
to
dd427bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## main #2522 +/- ##
==========================================
+ Coverage 72.17% 72.18% +0.01%
==========================================
Files 674 674
Lines 87831 87853 +22
==========================================
+ Hits 63395 63421 +26
+ Misses 24436 24432 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: xyz [email protected]
What's changed and what's your intention?
add support from number[int16/int32/int64/float32/float64/decimal] to varchar using to_string method
PLEASE DO NOT LEAVE THIS EMPTY !!!
Checklist
Refer to a related PR or issue link (optional)
#112