Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: binding struct values when they are parsed as row #2508

Merged
merged 4 commits into from
May 14, 2022

Conversation

cykbls01
Copy link
Contributor

@cykbls01 cykbls01 commented May 13, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Delete scalarImpl to datatype function since we can get the data type from literal.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #2508 (5401743) into main (3a21481) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2508   +/-   ##
=======================================
  Coverage   71.33%   71.34%           
=======================================
  Files         689      689           
  Lines       88645    88605   -40     
=======================================
- Hits        63234    63212   -22     
+ Misses      25411    25393   -18     
Flag Coverage Δ
rust 71.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/src/types/mod.rs 65.57% <ø> (+0.48%) ⬆️
src/common/src/types/scalar_impl.rs 59.84% <ø> (+2.44%) ⬆️
src/frontend/src/binder/values.rs 92.68% <100.00%> (ø)
src/common/src/array/struct_array.rs 83.58% <0.00%> (-0.92%) ⬇️
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cykbls01 cykbls01 marked this pull request as ready for review May 14, 2022 10:15
@cykbls01 cykbls01 merged commit 13d35d0 into main May 14, 2022
@cykbls01 cykbls01 deleted the refactor/insert_struct_data branch May 14, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants