feat: support information_schema.schemata #18709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezizp2012
approved these changes
Sep 25, 2024
| use risingwave_common::types::Fields; | ||
| use risingwave_frontend_macro::system_catalog; | ||
|
|
||
| /// The view schemata contains all schemas in the current database that the current user has access to (by way of being the owner or having some privilege). |
There was a problem hiding this comment.
Should we filter the result by the current user in a more strict way? Not familiar with this system catalog, since we don't support function like has_schema_privilege in rw, we can ignore that part for now.
It's also acceptable to me to keep the current impl.
There was a problem hiding this comment.
Oh, I found that the has_schema_privilege function exists in rw.
There was a problem hiding this comment.
Cool, Let me add it
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
information_schema.schemata