Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): correct release check #18666

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

cyliu0
Copy link
Collaborator

@cyliu0 cyliu0 commented Sep 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #18664

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@cyliu0 cyliu0 requested a review from lmatz September 24, 2024 08:08
@cyliu0 cyliu0 enabled auto-merge September 24, 2024 08:09
@cyliu0 cyliu0 requested a review from xxchan September 24, 2024 08:14
@cyliu0 cyliu0 added this pull request to the merge queue Sep 24, 2024
@graphite-app graphite-app bot requested a review from a team September 24, 2024 08:38
Merged via the queue into risingwavelabs:main with commit 75cc17b Sep 24, 2024
29 of 30 checks passed
@cyliu0 cyliu0 deleted the fix-release-script branch September 24, 2024 08:39
@cyliu0 cyliu0 added need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 labels Sep 25, 2024
cyliu0 added a commit that referenced this pull request Sep 25, 2024
lmatz pushed a commit that referenced this pull request Sep 26, 2024
lmatz pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release script will create duplicated tags
2 participants