feat(mqtt): Add max_packet_size option to MQTT Source #18520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florissmit10
force-pushed
the
feature/add-mqtt-max-packet-size-option
branch
from
54addf0 to
2b9d8f6
Compare
florissmit10
changed the title
|
Hello! |
florissmit10
changed the title
florissmit10
changed the title
Boudewijn26
reviewed
Sep 13, 2024
tabVersion
approved these changes
Sep 16, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The MQTT client that is used uses a default max_packet_size, which is not enough for our messages. This PR adds a WITH option that passes the max_packet_size to the MQTT client.
Checklist
./risedev check(or alias,./risedev c)Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
The MQTT Source connector now accepts an max_packet_size option