Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): support azblob file source #18295

Merged
merged 4 commits into from
Aug 28, 2024
Merged

feat(connector): support azblob file source #18295

merged 4 commits into from
Aug 28, 2024

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Aug 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, aligned with risingwave-cloud.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Add azblob file source, which is parallel to the existing s3 source, gcs source

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For all the newly supported backend for file source and sink, we need to certify that it can work from correctness, stability and security points of view via testing before we can release them officially to our user.

cc @st1page I think we can make them a preview feature first.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Aug 28, 2024

LGTM.

For all the newly supported backend for file source and sink, we need to certify that it can work from correctness, stability and security points of view via testing before we can release them officially to our user.

cc @st1page I think we can make them a preview feature first.

The newly added source and sink pr will be merged after I test it locally. But we will not test all file sink connector in CI or main-cron(gcs, azblob, etc. are not included in ci, only a minio connector is used for e2e test), as they are the same implementation, so I think test the connectivity locally is enough.

@wcy-fdu wcy-fdu added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 40074f6 Aug 28, 2024
29 of 30 checks passed
@wcy-fdu wcy-fdu deleted the wcy/azblob_source branch August 28, 2024 10:42
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
@wcy-fdu wcy-fdu added the need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants