-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): support azblob file source #18295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For all the newly supported backend for file source and sink, we need to certify that it can work from correctness, stability and security points of view via testing before we can release them officially to our user.
cc @st1page I think we can make them a preview feature first.
The newly added source and sink pr will be merged after I test it locally. But we will not test all file sink connector in CI or main-cron(gcs, azblob, etc. are not included in ci, only a minio connector is used for e2e test), as they are the same implementation, so I think test the connectivity locally is enough. |
Co-authored-by: congyi wang <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, aligned with risingwave-cloud.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Add azblob file source, which is parallel to the existing s3 source, gcs source