Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): allow upsert protobuf with text key #18024

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Aug 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

When creating a sink, format upsert encode protobuf (...) key encode text is now allowed. Note the key encode text part is required, unlike being optional for other format/encode combinations.

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangjinwu xiangjinwu force-pushed the feat-sink-encode-protobuf-key-text branch from 87613a6 to 5482bef Compare August 13, 2024 08:47
@graphite-app graphite-app bot requested a review from a team August 13, 2024 09:14
@xiangjinwu xiangjinwu added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit c6ed9bb Aug 13, 2024
30 of 31 checks passed
@xiangjinwu xiangjinwu deleted the feat-sink-encode-protobuf-key-text branch August 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants