feat(secret): add rw_catalog.rw_secrets table #17726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's discuss in slack channel. |
tabVersion
approved these changes
Jul 30, 2024
Comment on lines
+23
to
+27
| #[primary_key] | ||
| id: i32, | ||
| name: String, | ||
| owner: i32, | ||
| acl: String, |
There was a problem hiding this comment.
wish we could add a backend column for "meta" or "HashiCrop_Vault".
There was a problem hiding this comment.
Not viable for now because it's encrypted. We figure out what we can do after we add hashicorp
|
Please mark it as user-facing and add some release notes for it. |
yuhao-su
added
the
user-facing-changes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
add rw_catalog.rw_secrets table
One problem is secret backend was encrypted. So no backend info in the system table. @tabVersion
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
Add
rw_catalog.rw_secretscatalog table.Table schema:
id: id of secret object.name: name of the secretowner: owner of the secretacl: access control of the secret.