-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): support async function for captured context and impl pg_is_in_recovery(), rw_recovery_status() #17641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add support for a PG-compatible function indicating the status of RW cluster is good, but I'm wondering whether it's better to provide a customized function like rw_recovery_status
returning more detailed information (like distinguishing "starting" and "failure recovery") for internal usages such as Cloud.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #17522 . This PR supports async function for
capture_context
and implrw_recovery_status()
and realpg_is_in_recovery()
based on the status from meta node. The following is the code generated forrw_recovery_status
:The return value is one of the following ones:
STARTING
,RECOVERING
andRUNNING
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
Support function
rw_recovery_status
,pg_is_in_recovery
.