Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support async function for captured context and impl pg_is_in_recovery(), rw_recovery_status() #17641

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Jul 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #17522 . This PR supports async function for capture_context and impl rw_recovery_status() and real pg_is_in_recovery() based on the status from meta node. The following is the code generated for rw_recovery_status:

fn rw_recovery_status_impl(
    meta_client: &Arc<dyn FrontendMetaClient>,
) -> impl std::future::Future<Output = Result<RecoveryStatus>> + Send + 'static {
    let meta_client = meta_client.clone();
    async move {
        {
            meta_client
                .get_cluster_recovery_status()
                .await
                .map_err(|e| ExprError::Internal(e.into()))
        }
    }
}
async fn rw_recovery_status_impl_captured() -> Result<RecoveryStatus> {
    { META_CLIENT::try_with(|meta_client| rw_recovery_status_impl(meta_client)) }?.await
}

The return value is one of the following ones: STARTING, RECOVERING and RUNNING.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Support function rw_recovery_status, pg_is_in_recovery.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

src/expr/macro/src/context.rs Show resolved Hide resolved
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support for a PG-compatible function indicating the status of RW cluster is good, but I'm wondering whether it's better to provide a customized function like rw_recovery_status returning more detailed information (like distinguishing "starting" and "failure recovery") for internal usages such as Cloud.

Rest LGTM

src/meta/service/src/cluster_service.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yezizp2012 yezizp2012 changed the title feat(frontend): support async function for captured context and impl pg_is_in_recovery() feat(frontend): support async function for captured context and impl pg_is_in_recovery(), rw_recovery_status() Jul 10, 2024
@yezizp2012 yezizp2012 requested a review from BugenZhao July 10, 2024 08:49
@yezizp2012 yezizp2012 enabled auto-merge July 11, 2024 05:25
@yezizp2012 yezizp2012 added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 8c5f3e2 Jul 11, 2024
32 of 33 checks passed
@yezizp2012 yezizp2012 deleted the zp/pg_is_in_recovery branch July 11, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

risectl/sql command to check cluster status
4 participants