Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix unexpected l0->lbase input more than limit #11204

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Jul 25, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #11154

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@Li0k Li0k requested review from Little-Wallace and zwang28 July 25, 2023 08:29
@github-actions github-actions bot added the type/fix Bug fix label Jul 25, 2023
@Li0k Li0k changed the title fix(storage): fix issue 11154 fix(storage): fix unexpected l0->lbase input more than limit Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #11204 (1e73a37) into main (04a28e7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #11204   +/-   ##
=======================================
  Coverage   69.67%   69.67%           
=======================================
  Files        1351     1351           
  Lines      224550   224600   +50     
=======================================
+ Hits       156445   156491   +46     
- Misses      68105    68109    +4     
Flag Coverage Δ
rust 69.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../compaction/picker/base_level_compaction_picker.rs 97.85% <100.00%> (+0.29%) ⬆️
...compaction/picker/min_overlap_compaction_picker.rs 99.04% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Li0k
Copy link
Contributor Author

Li0k commented Jul 25, 2023

  • nexmark q4
image
  • longevity test
image image

Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Li0k Li0k enabled auto-merge July 26, 2023 03:41
@Li0k Li0k added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 18e48da Jul 26, 2023
@Li0k Li0k deleted the li0k/storage_fix_issue_11154 branch July 26, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(compaction): unexpected l0->lbase task including more l0 inputs than level0_max_compact_file_number
3 participants