fix(common): decimal round digits test (#8568)

Co-authored-by: Noel Kwan <[email protected]>
risingwavelabs · Mar 16, 2023 · 30a8946 · 30a8946
1 parent 88550e4
commit 30a8946
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/expr/src/vector_op/round.rs b/src/expr/src/vector_op/round.rs
@@ -78,8 +78,10 @@ mod tests {
         do_test("84818.33333333333333333333333", 4, "84818.3333");
         do_test("84818.15", 1, "84818.2");
         do_test("21.372736", -1, "0");
-        // Maximum of 28 digits
-        do_test("0", 340, &format!("0.{}", "0".repeat(28)));
+        // When digit extends past original scale, it should just return original scale.
+        // Intuitively, it does not make sense after rounding `0` it becomes `0.000`. Precision
+        // should always be less or equal, not more.
+        do_test("0", 340, "0");
     }
 
     #[test]