Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace toml_edit with basic-toml #780

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Replace toml_edit with basic-toml #780

merged 2 commits into from
Feb 21, 2023

Conversation

Kijewski
Copy link
Collaborator

This removes a bunch of transitive dependencies (e.g. "nom8`), and we can use borrowed strings again.

djc
djc approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@djc djc merged commit 70c5784 into rinja-rs:main Feb 21, 2023
@Kijewski Kijewski deleted the pr-basic-toml branch February 21, 2023 16:11
@djc djc mentioned this pull request Feb 26, 2023
Closed
@Kijewski Kijewski mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kijewski @djc