Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid check #678

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix invalid check #678

merged 1 commit into from
Apr 26, 2022

Conversation

GuillaumeGomez
Copy link
Collaborator

block_start is already checked just above.

Also a question about this code: shouldn't the character in common be between *_start and *_end instead of the current code?

@Kijewski
Copy link
Collaborator

I'm not even sure if the two characters requirement couldn't be relaxed. I guess it speeds up the parsing, but I don't think that parsing the templates will take up much of the compiling time of a non-trivial project.

@GuillaumeGomez
Copy link
Collaborator Author

Considering it's config setup, I'm not even sure if it'd have any impact at all...

@Kijewski
Copy link
Collaborator

Hehe, I meant the code of the parser. But no, e.g. https://github.com/djc/askama/blob/7238fe2971917f547498e761ff252244cd5c992d/askama_shared/src/parser.rs#L213-L217 does not care how long the delimiters are. Nevertheless, this could be be changed in another PR.

@Kijewski Kijewski merged commit c319691 into rinja-rs:main Apr 26, 2022
@GuillaumeGomez GuillaumeGomez deleted the patch-1 branch April 26, 2022 20:10
@GuillaumeGomez
Copy link
Collaborator Author

Oh indeed. Please open an issue! :D

@djc djc mentioned this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants