Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimize config for whitespace and add handling of ~ in the jinja parser #673

Merged
merged 7 commits into from
Apr 26, 2022
Merged

Add minimize config for whitespace and add handling of ~ in the jinja parser #673

merged 7 commits into from
Apr 26, 2022

Conversation

GuillaumeGomez
Copy link
Collaborator

Fixes #671.

@GuillaumeGomez GuillaumeGomez force-pushed the minimize-config branch 2 times, most recently from b9795a4 to 2f46506 Compare April 21, 2022 14:57
djc
djc reviewed Apr 21, 2022
View reviewed changes
askama_shared/src/generator.rs Outdated Show resolved Hide resolved
djc
djc reviewed Apr 21, 2022
View reviewed changes
askama_shared/src/generator.rs Outdated Show resolved Hide resolved
askama_shared/src/generator.rs Outdated Show resolved Hide resolved
askama_shared/src/parser.rs Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the minimize-config branch 2 times, most recently from faee8ab to c4262e1 Compare April 21, 2022 18:06
@GuillaumeGomez
Copy link
Collaborator Author

Updated!

djc
djc approved these changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Any other opinions?

@djc djc merged commit f997ba9 into rinja-rs:main Apr 26, 2022
@djc
Copy link
Collaborator

djc commented Apr 26, 2022

Thanks!

@GuillaumeGomez GuillaumeGomez deleted the minimize-config branch April 26, 2022 08:31
@Kijewski Kijewski mentioned this pull request May 21, 2022
Closed
@djc djc mentioned this pull request Feb 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vallentin vallentin vallentin left review comments

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim all but 1 whitespace jinja condition
3 participants
@GuillaumeGomez @djc @vallentin