Moved Features into derive #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could not reopen the old PR since you closed it. @Kijewski |
Any I could not reopen it, because it was synchronous to main after my mistake. :-/ Could you please unpick the last commit? 0.11.2 is fine. It tells cargo that any version 0.11.[2, 3, 4…] is okay, which is exactly what we want to express. :) |
|
I have done so. It is hard to tell exactly what was wanted =]. @Kijewski |
jplatte
approved these changes
Apr 6, 2022
|
It's failing CI. Should fix that? Otherwise, LGTM. |
|
@djc, some action runners haven't updated their rust nightly, yet, and are still affected by rust-lang/rust#95728. Running the test again solves it (often). |
Kijewski
approved these changes
Apr 6, 2022
|
Thank you for the fix, @genusistimelord! :) |
This was referenced Apr 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crosses fingers as this is just a force push of the last changes....
@Kijewski