Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow whitespace trimming in {{raw}} blocks #546

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Allow whitespace trimming in {{raw}} blocks #546

merged 1 commit into from
Nov 30, 2021

Conversation

Kijewski
Copy link
Collaborator

This PR is based on #545 and #541.

djc
djc previously approved these changes Nov 24, 2021
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After rebasing this on top of main, feel free to merge it!

@Kijewski
Copy link
Collaborator Author

Huh, do you know why the CI isn't checking the PR?

@djc
Copy link
Collaborator

djc commented Nov 25, 2021

Probably just a glitch, try pushing it again?

@Kijewski
Copy link
Collaborator Author

The main branch is protected, so I cannot push directly to it without an approval, and I cannot self-approve my PR. So, you or @vallentin need to approve the PR. :)

Copy link
Collaborator

@vallentin vallentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc said it was all good, so just approving so you can merge :)

@Kijewski Kijewski merged commit 1762792 into rinja-rs:main Nov 30, 2021
@Kijewski Kijewski deleted the pr-fix-raw branch November 30, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants