Add routerify integration #487
Conversation
|
This can also be generalized as a hyper integration since there is not any routerify specific code here. |
| readme = "README.md" | ||
| edition = "2018" | ||
|
|
||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html |
| buf.writeln(&format!("::askama_routerify::respond(&self, {:?})", ext))?; | ||
| buf.writeln("}")?; | ||
| buf.writeln("}") | ||
| } | ||
| // Writes header for the `impl` for `TraitFromPathName` or `Template` |
There was a problem hiding this comment.
Add an empty line here below the new method?
| [dependencies] | ||
| askama = { version = "0.10.6", path = "../askama", default-features = false, features = ["with-routerify", "mime", "mime_guess"] } | ||
| hyper = "0.14" | ||
| routerify = "2.1" |
There was a problem hiding this comment.
Also, move routerify to be a dev dep.
There was a problem hiding this comment.
If we turn this to askama_hyper I think we can drop it completely
|
Did most of the stuff but the problem is we need the client feature of hyper on testing. It looks like testing only features is a open issue on cargo repo. So I don't know how to test the hyper code. Any idea? |
|
Sorry, not sure what you mean, can you give me more context for what you're trying to do? |
|
We test the http framework integrations and testing actix one is kinda hard since we need some kind of client or optionally activate the client feature on tests (i dont think this one is possible). |
|
You can just repeat the dependency in the dev-dependencies with the extra feature added? |
closes #484