Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: add harness for filters and escape #1069

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

manunio
Copy link
Contributor

@manunio manunio commented Jun 18, 2024

This pr:

  • Adds a harness for filters and escape, this has helped in finding bugs like https://github.com/djc/askama/pull/1067
  • Moves all fuzz targets to a root fuzz crate, I think this approach is better than creating it per crate.

@manunio
Copy link
Contributor Author

manunio commented Jun 18, 2024

Fuzzing failure will be solved once this pr and the google/oss-fuzz#12084 merges.
Edit: All checks are green at oss-fuzz so this is safe to merge.

@djc
Copy link
Collaborator

djc commented Jun 18, 2024

Would you mind making this two separate commits (or PRs)? One that moves the existing parser fuzz tests to the new crate, and a separate one that adds the new filter tests.

@manunio
Copy link
Contributor Author

manunio commented Jun 18, 2024

Would you mind making this two separate commits (or PRs)? One that moves the existing parser fuzz tests to the new crate, and a separate one that adds the new filter tests.

Sure, no problem.

@manunio manunio force-pushed the fuzz-add-targets branch from 67bb3be to 167eb0b Compare June 18, 2024 10:09
@djc djc merged commit 2d7ecdf into rinja-rs:main Jun 18, 2024
16 of 17 checks passed
@manunio manunio deleted the fuzz-add-targets branch June 18, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants