-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix Cache Aware Scheduling #1
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
FILL IN THE PR DESCRIPTION HERE
FIX vllm-project#7883 in V0
Problem and Motivation
With current impl in main, there are at least 2 places where scheduling is not optimal:
This would result in under-utilization of KV cache, and un optimal scheduling decision for a batch.
For more details, see the vllm-project#7883
High Level Approach
This PR addresses the issue by:
On a high level, there are below major changes.
Benchmark
With the PR
It's worth noting that:
max_num_batched_tokens
to take into account prefix-cached tokens if the prefix cache hit rate could be known in advance.