Skip to content

Commit

Permalink
build: enable --error-on-warn for POSIX workflows
Browse files Browse the repository at this point in the history
Treat warnings as errors for non-deps code on Linux and macOS workflows.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: nodejs#33357
Refs: nodejs#32685
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
  • Loading branch information
richardlau committed May 13, 2020
1 parent 3aa5152 commit fcc183c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j2 V=1
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
- name: Test
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
2 changes: 1 addition & 1 deletion .github/workflows/test-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: make build-ci -j8 V=1
run: make build-ci -j8 V=1 CONFIG_FLAGS="--error-on-warn"
- name: Test
run: make run-ci -j8 V=1 TEST_CI_ARGS="-p dots"

0 comments on commit fcc183c

Please sign in to comment.