fix(graph): Don't return OCM shares in the drives list

OCM shares don't have mountpoints currently. So they're no supposed to show up in the drives list on the graph service. Fixes: owncloud#10689
rhafer · Dec 4, 2024 · b74de4c · b74de4c
1 parent e08899d
commit b74de4c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/changelog/unreleased/me_drives_ocm_shares.md b/changelog/unreleased/me_drives_ocm_shares.md
@@ -0,0 +1,7 @@
+Bugfix: Fix graph drives response for federated shares
+
+Federated shares where erroneously showing up in the /me/drives response
+on the graph API.
+
+https://github.com/owncloud/ocis/pull/1xxxx
+https://github.com/owncloud/ocis/issues/10689
diff --git a/services/graph/pkg/service/v0/drives.go b/services/graph/pkg/service/v0/drives.go
@@ -645,6 +645,10 @@ func (g Graph) formatDrives(ctx context.Context, baseURL *url.URL, storageSpaces
 	for i := 0; i < numWorkers; i++ {
 		errg.Go(func() error {
 			for storageSpace := range work {
+				if storageSpace.GetRoot().GetStorageId() == utils.OCMStorageProviderID {
+					// skip OCM shares they are no supposed to show up in the drives list
+					continue
+				}
 				res, err := g.cs3StorageSpaceToDrive(ctx, baseURL, storageSpace, apiVersion)
 				if err != nil {
 					return err