Bring back memory optimization of caching lowercased node name #185
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4.6.2, rgrove#175 significantly cut down on memory usage by caching the lowercase version of the node name. However, as reported in rgrove#177, this broke certain transformers that modified the node name since the name was cached. We can bring back this optimization by updating the node name only if it has been changed. Closes rgrove#184
rgrove
reviewed
Jul 24, 2018
|
|
||
| # It's possible that a transformer modifies the node name, so only | ||
| # copy the string again if it has changed. | ||
| node_name = node.name.downcase if node.name != node_name |
There was a problem hiding this comment.
We need to account for the possibility that node.name and node_name won't have the same case.
One possible optimization would be to compare the downcased node name with the original name at the start of transform_node! (and whenever the node name changes) and use that knowledge to decide whether we need to do a case-insensitive equality check in future iterations of the loop (probably using casecmp).
My guess is that 99+% of the time this would let us skip using casecmp in the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.6.2, #175 significantly cut down on memory usage by caching the lowercase
version of the node name. However, as reported in #177, this broke certain
transformers that modified the node name since the name was cached. We can
bring back this optimization by updating the node name only if it has been
changed.
Closes #184