Use the built-in generic C build rules #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch breaks the build on Linux. I think something is wrong with the order of the compiler flags |
|
If these are not independent patches, then please merge them into one. |
These are almost always more correct in terms of being "standard", properly accepting the flags, etc.
vifon
force-pushed
the
makefile_builtin_rules
branch
from
2fd1584 to
a3e99c0
Compare
|
Right, I can and should (and just did) do it on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are almost always more correct in terms of being "standard", properly accepting the flags, etc. For instance they correctly use both
LDFLAGSandLDLIBS, see #45.