Tag interfering with Xpath fix #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarsier/tag_utils.ts
Outdated
| const elTagName = el.tagName.toLowerCase(); | ||
| const idStr = inputTags.includes(elTagName) ? `{${idNum}}` : `[${idNum}]`; | ||
| // const idStr = inputTags.includes(elTagName) ? `{${idNum}}` : `[${idNum}]`; |
There was a problem hiding this comment.
Can we jus delete the commented code?
| @@ -162,36 +162,69 @@ window.tagifyWebpage = (tagLeafTexts = false) => { | |||
| continue; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Functions a bit long and hard to read. Ideally we broke this apart but given this is a js utility file in a python project this should be fine.
awtkns
reviewed
Nov 27, 2023
tarsier/tag_utils.ts
Outdated
| idToXpath[idNum] = getElementXPath(el); | ||
|
|
||
| // create the span for the id tag | ||
| // let idSpan = create_tagged_span(idStr); |
There was a problem hiding this comment.
We should remove all commented out code
| const interactable = isInteractable(el); | ||
| const elTagName = el.tagName.toLowerCase(); | ||
| const idStr = inputTags.includes(elTagName) ? `{${idNum}}` : `[${idNum}]`; | ||
|
|
||
| // create the span for the id tag | ||
| let idSpan = create_tagged_span(idStr); |
| } else if (elTagName === "select") { | ||
| // leave select blank - we'll give a tag ID to the options | ||
| } | ||
| } else { |
There was a problem hiding this comment.
can this be simplified? This can be combined with the statement above
awtkns
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserting the tag while calculating the xpaths for elements was resulting in the tarsier tags interfering with xpath indexing for spans. I separated tag insertion out to a separate loop that runs after xpaths are calculated.