Only support ARMv6 on ARM platforms #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
support-armv6
branch
from
930d963 to
ec0847e
Compare
I think the Raspberry Pi 1 is not the main cause. Raspberry Pi 1 is probably not used widely anymore. However the popular Raspberry PI Zero W is also based on ARMv6. I am using 3 Raspberry PI Zero W and therefore need the ARMv6 support. |
That information is missing from #4540. There only the "Raspberry Pi" was mentioned. I only intend to deprecate ARMv5, not later versions of the instruction set. |
Go 1.21 has switched the default from GOARM=5 to GOARM=7. So far there have been complaints from Raspberry Pi 1 users, as the first raspberry pi version only supports ARMv6. Exclude older ARM versions as these are likely not relevant (rest-server also only supports ARMv6/7) and enforce the use of software floating point emulation.
MichaelEischer
force-pushed
the
support-armv6
branch
from
ec0847e to
5166bde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Go 1.21 has switched the default from GOARM=5 to GOARM=7. So far there have been complaints from Raspberry Pi 1 users, as the first raspberry pi version only supports ARMv6. Exclude older ARM versions as these are likely not relevant (rest-server also only supports ARMv6/7) and enforce the use of software floating point emulation.
This also fixes the mislabeling of our docker containers as linux/arm/v7 when the contained binary actually only required linux/arm/v5
Was the change previously discussed in an issue or on the forum?
Fixes #4540
Checklist
[ ] I have added tests for all code changes.[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.