Use project.version instead of tagName for commit messages of version change commits #336
Conversation
…commit message that changes project version
kristofpeto-tesco
changed the title
| @@ -66,4 +68,29 @@ class GitReleasePluginCommitNewVersionTests extends GitSpecification { | |||
| remoteGit.repository.workTree.listFiles().any { it.name == 'gradle.properties' && it.text.contains("version=$project.version") } | |||
| ! remoteGit.repository.workTree.listFiles().any { it.name == 'test.txt' && it.text.contains('testTarget') } | |||
| } | |||
|
|
|||
| def 'should push new version to remote tracking branch with custom commit message as prefix for project version'() { | |||
There was a problem hiding this comment.
This test is passing without my change, as tagTemplate's default is '$version'
|
Hey @kristofpeto-tesco, TravisBuddy Request Identifier: bcd5e5e0-ab41-11ea-b056-2f6ef3b381c7 |
|
Hey @kristofpeto-tesco, TravisBuddy Request Identifier: 8b794d90-ab44-11ea-b056-2f6ef3b381c7 |
| revCommit.getShortMessage().equals("New snapshot version: '1.2-SNAPSHOT'.") | ||
| } | ||
|
|
||
| def 'it is project.version that is present in commit message, and not tagTemplate'() { |
There was a problem hiding this comment.
This test is failing without my change.
|
Hey @kristofpeto-tesco, TravisBuddy Request Identifier: 2af4b790-ab47-11ea-b056-2f6ef3b381c7 |
|
@WtfJoke can you please take a look at this? |
|
@kristofpeto-tesco Im not a maintainer of this project. 😅 Have a little bit patience, #327 took 4 months in order to get merged ;) |
|
@Hillkorn, can you please take a look at this PR, it is quite a small change and is straightforward I believe. |
|
@Hillkorn , kind reminder, can you please review this PR? :) |
|
Hey I think if we want to change this we should have a configurable template with the behavior as a default here instead of changing it to the project version. I prefer the tagName() because if you have a multi project setup and use the project name in your tag to make it unique you will have it in the commit message too. |
|
@kristofpeto-tesco Sorry, but @Hillkorn is absolutely right. Default tagName already does what you want to achieve. I think this PR should be closed. |
Specifying the tagTemplate should not influence the commit message of the commits that change the project version during the release process.