Add skipUserProfile option for Generic OpenID Connect / OAuth2 Authentication #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
approved these changes
Mar 17, 2023
davidflypei
pushed a commit
to davidflypei/wiki
that referenced
this pull request
Jun 13, 2023
Co-authored-by: Robin Chalmers <[email protected]>
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
Co-authored-by: Robin Chalmers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new option "skip user profile" to the settings for the Generic OpenID Connect / Oauth2 authentication. The default is false. This exposes the option to skipUserProfile which is configurable in the underlying library that WikiJS uses: passport-openidconnect
The advantage of having this option is so that we can integrate with CIAM (customer identity access management) solutions such as Azure AD B2C which do NOT have the UserInfo endpoint as default.
Furthermore, it seems that WikiJS does not actually use the UserInfo endpoint for anything, as the Display name is taken from the email claim.
The change has been tested with Azure AD B2C and works well. NOTE: A custom policy is still required on this platform in order to return the "email" claim!