-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve System Test performance with stubbing dotnet new #294
Conversation
I added a fix for the Linux build (a replacement for the dictionary separator |
@obligaron super, thx! Could you please make a review of the rest of the PR? |
Update: Ignore this, I added this command already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🙂
🤔 What's changed?
The
TestProjectGenerator
that is used by System Tests (and currently Specs tests as well) has been improved:dotnet new sln
and thedotnet new classlib
commands have been replaced by a "stub" version that calls the original command first, but caches the result in the temp folder and for the next time it only copies the filesdotnet sln add
command has been replaced by a stub implementation that does the same by editing the.sln
file directly⚡️ What's your motivation?
The main motivation is performance as these three basic command take significant time in local and CI execution.
With the changes I have achieved a good performance improvement locally:
I also hope that this fixes #249 too.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
It can happen that this changed the behavior of #109, so that needs to be retested.
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.