fix: sanitizeMarkdown on packageName & prTitle #8795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please create an issue to discuss the problem and possible solutions first. The solution you propose is now resulting in some double escaping, which is not ideal. |
5 tasks
|
@ThibautMarechal Can you rebase your branch onto latest |
JamieMagee
reviewed
May 19, 2021
lib/workers/pr/body/index.spec.ts
Outdated
|
|
||
| import { getPrBody } from '.'; | ||
|
|
||
| describe('workers/pr/body', () => { |
There was a problem hiding this comment.
Suggested change
| describe('workers/pr/body', () => { | |
| describe(getName(), () => { |
JamieMagee
reviewed
May 19, 2021
lib/workers/pr/body/index.spec.ts
Outdated
| @@ -0,0 +1,41 @@ | |||
| import { platform } from '../../../../test/util'; | |||
There was a problem hiding this comment.
Suggested change
| import { platform } from '../../../../test/util'; | |
| import { getName, platform } from '../../../../test/util'; |
JamieMagee
reviewed
May 19, 2021
viceice
reviewed
May 20, 2021
lib/workers/pr/body/index.spec.ts
Outdated
Comment on lines
6
to
11
| jest.mock('./config-description', () => ({ | ||
| getPrConfigDescription: jest.fn(() => ''), | ||
| })); | ||
| jest.mock('./controls', () => ({ | ||
| getControls: jest.fn(() => ''), | ||
| })); |
There was a problem hiding this comment.
Suggested change
| jest.mock('./config-description', () => ({ | |
| getPrConfigDescription: jest.fn(() => ''), | |
| })); | |
| jest.mock('./controls', () => ({ | |
| getControls: jest.fn(() => ''), | |
| })); | |
| jest.mock('./config-description'); | |
| jest.mock('./controls'); |
just use default mocks jests will do it's magic 🧙
lib/workers/pr/body/index.spec.ts
Outdated
| let config: RenovateConfig; | ||
| beforeEach(() => { | ||
| config = getConfig(); | ||
| platform.massageMarkdown = jest.fn((input) => input); |
There was a problem hiding this comment.
Suggested change
| platform.massageMarkdown = jest.fn((input) => input); | |
| platform.massageMarkdown.mockImplementation((input) => input); |
platform.massageMarkdown is already a mock 😉
|
Snapshots need to be updated |
rarkins
approved these changes
May 24, 2021
rarkins
reviewed
May 24, 2021
rarkins
requested changes
May 24, 2021
This still applies |
|
@ThibautMarechal were you able to verify this on one or more public repos? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Use sanitizeMarkdown for PrTitle & PackageName in the update table & onboarding pr-list.
Context:
I have a weird behavior using the platform bitbucket-server. Adding the zero-width character after the '@' fixed the issue.
it display '@testing/react-autosuggest' but the real packageName is '@type/react-autosuggest'.
(@ testing is coming from the package above)
It only hapend when the packageName is in a link.
It's now fixed by the sanitizeMarkdown function.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: