Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#334] Fix keyboard on macOS #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cpick
Copy link

@cpick cpick commented May 16, 2022

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Pick seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cpick cpick force-pushed the 334-macos_keyboard branch from b335d44 to ebe435b Compare May 16, 2022 00:40
Copy link
Member

@mateusz-holenko mateusz-holenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the code looks fine.

Please remember that, like in case of many other open-source projects, in order to merge your code to Renode you need to first sign the CLA.

@kotval
Copy link

kotval commented Dec 6, 2022

If I implemented the requested changes, can this be merged or do we need the other contributor to sign the license agreement as well?

@pgielda
Copy link
Member

pgielda commented Jan 8, 2024

Yes, @cpick has to sign the CLA or it has to be implemented from scratch (unless you have a right to sign CLA for this code, e.g. if you work at the same company/institution and this code is owned by this company and you are allowed to sign CLAs on behalf of this company/institution)

@cpick
Copy link
Author

cpick commented Jan 17, 2024

Thanks for the response.

I'm not interested in signing a CLA that would allow my contribution to be used under a license that I may not support in the future.

@cpick cpick force-pushed the 334-macos_keyboard branch from f8f02c1 to 68144f8 Compare July 2, 2024 18:18
@cpick cpick force-pushed the 334-macos_keyboard branch from 68144f8 to 8b9c49c Compare July 2, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard not working on macOS
5 participants