-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#334] Fix keyboard on macOS #68
base: master
Are you sure you want to change the base?
Conversation
Chris Pick seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise the code looks fine.
Please remember that, like in case of many other open-source projects, in order to merge your code to Renode you need to first sign the CLA.
If I implemented the requested changes, can this be merged or do we need the other contributor to sign the license agreement as well? |
Yes, @cpick has to sign the CLA or it has to be implemented from scratch (unless you have a right to sign CLA for this code, e.g. if you work at the same company/institution and this code is owned by this company and you are allowed to sign CLAs on behalf of this company/institution) |
Thanks for the response. I'm not interested in signing a CLA that would allow my contribution to be used under a license that I may not support in the future. |
Fixes renode/renode#334