Allow HashRouter URL without leading slash #8463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejohnhoffer
force-pushed
the
dev-depend-on-history-noslash
branch
from
6643478 to
009909e
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
thejohnhoffer
force-pushed
the
dev-depend-on-history-noslash
branch
from
009909e to
a552625
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
This was referenced Dec 10, 2021
thejohnhoffer
commented
Dec 10, 2021
| @@ -41,7 +41,7 @@ | |||
| "eslint-plugin-jsx-a11y": "^6.4.1", | |||
| "eslint-plugin-react": "^7.24.0", | |||
| "eslint-plugin-react-hooks": "next", | |||
| "history": "^5.0.0", | |||
| "history-noslash": "^5.2.0-noslash.2.0", | |||
There was a problem hiding this comment.
If PR #911 of history is merged, I’d update this dependency.
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
thejohnhoffer
force-pushed
the
dev-depend-on-history-noslash
branch
from
915ad90 to
e026838
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
As Ryan mentioned, this isn't going to be implemented: #8460 (comment) |
brophdawg11
pushed a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #8459.
This is an alternative to PR #8460. It is cleaner but also requires another pull request to
remix-run/history.The difference allows
HashRouterto have paths are written to the URL like#abcinstead of#/abc.I understand if the contributors have a preference to not allow this behavior, but I thought I'd present another attempt. I'm happy to write tests for this PR if anyone is willing to consider it.