Fix typegen watcher leak on dev restart #12331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the dev server is restarted (e.g. when Vite config changes) the old file watcher is still hanging around, with the following showing up in the terminal:
MaxListenersExceededWarning: Possible EventEmitter memory leak detected.
I've confirmed that when restarting the dev server, Vite calls the
buildEnd
hook, so to fix this we need to ensure the typegen watcher is cleaned up at the same time.Note that this is a minimal fix that aims to maintain the current architecture as much as possible, but I think it'd be worth following up with making the typegen code accept a
ConfigLoader
so that it can be shared with the Vite plugin rather than having two instances of it.