Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix nodelist abbreviation when last node number is a multiple of 10 #3339

Merged

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Dec 5, 2024

Closes #3338.

@vkarak vkarak added this to the ReFrame 4.8 milestone Dec 5, 2024
@vkarak vkarak requested review from ekouts, victorusu and teojgo December 5, 2024 21:09
@vkarak vkarak self-assigned this Dec 5, 2024
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Great catch!

@vkarak
Copy link
Contributor Author

vkarak commented Dec 6, 2024

lgtm. Great catch!

Kudos to @harrysorensennrel for catching this.

@vkarak vkarak enabled auto-merge December 6, 2024 09:54
@vkarak vkarak merged commit 3dafd84 into reframe-hpc:master Dec 6, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Slurm node abbreviation fails for sequential nodes when the last node number is a power of 10
2 participants